Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trendline options #2997

Merged
merged 24 commits into from
Aug 13, 2021
Merged

Trendline options #2997

merged 24 commits into from
Aug 13, 2021

Conversation

nicolaskruchten
Copy link
Contributor

@nicolaskruchten nicolaskruchten commented Dec 29, 2020

Refactors trendline code to extract a common interface (an ugly one!), including an options dict, which enables new functions like rolling mean (needed an argument for the window size at least!) and OLS options like log_x and add_constant, plus a configurable LOWESS frac parameter.

Code PR

  • I have added tests (if submitting a new feature or correcting a bug) or
    modified existing tests.
  • For a new feature, I have added documentation examples in an existing or
    new tutorial notebook (please see the doc checklist as well).
  • I have added a CHANGELOG entry if fixing/changing/adding anything substantial.
  • For a new feature or a change in behaviour, I have updated the relevant docstrings in the code to describe the feature or behaviour (please see the doc checklist as well).

@nicolaskruchten nicolaskruchten marked this pull request as ready for review August 13, 2021 02:27
@nicolaskruchten nicolaskruchten merged commit ed48215 into master Aug 13, 2021
@archmoj archmoj deleted the trendlines2 branch November 23, 2021 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant